General improvements and Azure rework #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… moved some code to internal package
…plemented RG filtering
…emented RG filtering
…[string][]subscription populated prior to run any module
…tenant and subscription ID manipulation
… and subscription ID manipulation
…scription and tenant iteration mechanisms
….com/BishopFox/cloudfox into general-improvements_azure-commands
…s, included in target subnets
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This is my take on the Azure side of the tool, where I tried to have a similar approach to have we have already for AWS. This allowed a much more flexible structure without passing arguments to function everywhere, and it also significantly reduces the amount of repeated code across the modules.
I also implemented a much more flexible resource selection mechanism for Azure resources, where you could select multiple tenants, subscriptions, resource groups and resource identifiers for targeted reviews.
Not all modules do use that level of granularity during their execution but at least it is available to all modules to a specialized Azure Client.
I also gave a shot to a centralized logged that all modules and cloud providers could use. We would have to chat more about it to see how we could apply it to existing AWS modules.