Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonization of MSI function #1

Open
drnickisaac opened this issue Dec 8, 2017 · 3 comments
Open

Harmonization of MSI function #1

drnickisaac opened this issue Dec 8, 2017 · 3 comments

Comments

@drnickisaac
Copy link
Contributor

drnickisaac commented Dec 8, 2017

@AugustT
MSI function is currently not compatible with the data structure for bma functions. I can convert it as follows

msi_data <- data_in
msi_data$species <- as.factor(as.character(msi_data$species))
msi_data$index <- 10^(msi_data$index) # puts the data on the measurement scale
msi_data$se <- msi_data$index * msi_data$se # delta method - the function actually does the reverse

But it would be better if all the functions accepted data in the same format. Either a wrapper function would do this conversion so that the published version of the MSI function would still be accessible OR allow input options within the function.

@drnickisaac drnickisaac changed the title Harmonization of MSI Harmonization of indicator functions Dec 8, 2017
@drnickisaac drnickisaac changed the title Harmonization of indicator functions Harmonization of MSI function Dec 8, 2017
@AugustT
Copy link
Member

AugustT commented May 22, 2018

will be addressed

@drnickisaac drnickisaac added this to the Sprint October 2019 milestone Oct 3, 2019
@drnickisaac
Copy link
Contributor Author

I'll be visiting Arco & Leo in the Hague soon after the Sprint, so I'd like to make this a priority

@AugustT
Copy link
Member

AugustT commented Oct 14, 2019

Note that this is a sub-issue of #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants