Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment required for 250W Mercury Vapour lamp type term (E40 not E27) #700

Open
andrewvanbreda opened this issue Jun 24, 2024 · 10 comments
Assignees

Comments

@andrewvanbreda
Copy link
Collaborator

As noted by @larspett in issue #664
There appears to be an issue with the existing E27 250W Mercury Vapour lamp type term hierarchy,

From Lars
"the 250W Mercury Vapour isn’t E27, that socket is E40.".

I note this seems to be controlled by this hierarchical termlist, and I note the parent ID of different terms can't be switched in the Warehouse UI.

https://warehouse1.indicia.org.uk/index.php/termlist/edit/987?tab=terms

Is this something you can pick up @JimBacon with a DB tweak?

Thanks

Andy

@andrewvanbreda
Copy link
Collaborator Author

Note there does appear to be a "Parent term" field on the Warehouse terms, but I tested changing that on a termlist on my own machine, and the change is not saved so I don't think terms can be switched around in that way.

@andrewvanbreda
Copy link
Collaborator Author

Hi @larspett
Can I just double check something.
It is just the 250W Mercury Vapour that needs changing?, not everything that was E27?
I am just double checking because the fix is very different if it were everything, I am assuming it is just the 250W as you noted.

@larspett
Copy link
Collaborator

larspett commented Jun 25, 2024 via email

@andrewvanbreda
Copy link
Collaborator Author

@larspett
Thank you for the confirmation.

@JimBacon
Copy link
Member

I'm just using Google to try to confirm the sizes as it seemed unlikely that the 500W would be E27 if the 250W is E40.
If these are the lamps ML family made by Philips then it seems they do not make a 250W lamp in this family. It does confirm the 500W is E40.

However, there is a 250W/E40 lamp in the HPL family

The options we currently have are

  • E27 ML 160W
  • E27 ML 250W
  • E27 ML 500W
  • E27 HPL 125W
  • E27 HPL 400W

My search suggests this should be

  • E27 ML 160W
  • E40 ML 500W
  • E27 HPL 125W
  • E40 HPL 250W
  • E40 HPL 400W

Could this be consistent with your experience @larspett? Another possibility is that a ML/250W was made previously although there is actually evidence of this having existed with an E27 fitting. (Or, indeed, with both!)

It may be the case that we have to add an E40 category with ML/500W, HPL/250W and HPL/400W while retaining the existing E27 options.

@larspett
Copy link
Collaborator

larspett commented Jun 25, 2024 via email

@JimBacon
Copy link
Member

I've added new options for the 3 lamps available in E40 fittings.

I marked the corresponding options for lamps with E27 fittings as 'not for data entry', in the hope that this will prevent them being offered as options for new records while not affecting existing records. That doesn't seem to have worked which is a separate issue.

I have not modified records which use the E27 options. That is still an option but, from the point of view of a moth, I don't think the electrical fitting will be particularly important.

@larspett
Copy link
Collaborator

larspett commented Jun 26, 2024 via email

@JimBacon
Copy link
Member

Moth records are linked to site-trap-lamp records so, if you change a site-trap-lamp to use a different lamp, older moth records, when queried, will show the revised lamp details.

If you were to change a lamp from 250W to 400W then a new site-trap-lamp record needs to be created so that older moth records continue to link to the 250W lamp while new ones link to the 400W lamp. (I feel like the website should issue a warning to users about this.)

Updating the settings for the website will not propagate to the app if I read the comment from @kazlauskis correctly.

@larspett
Copy link
Collaborator

larspett commented Jun 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants