-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properties for LabProtocol and LabProcess #675
Comments
Hi Marco, thanks for your input! Here are a few comments on what you wrote. Looking forward to discuss this in our meeting.
The current
This indeed fits to what we explained above: annotating reagents and software as parameters should be perfectly fine. We believe the important part is to make a clear distinction between constant and variable properties in the vocabulary, but of course reagents and softwares can be both. As a short remark, we don't think that FormalParameter fits into the range of components and parameters, as it has a completely different semantic interpretation strictly tied to computational workflows.
As you stated, |
Hi @floWetzels, thank you for your comments and sorry for my late reply.
I understand this as follow: I could define an RDF resource (URI) that is an instance of A reagent could be made an instance of PV too, but too ugly. An alternative is to model a reagent as a reagent when it's a constant and as a PV (with name and value) when it varies. This is problematic because it introduces two different ways to model the same thing. So, another option is what I was initially saying: properties like reagent could be used for LabProcess too, they could even be sub-properties of
I see a couple of issues with this (similar ones occur here and there in both schema.org and Bioschemas):
inheriting from the top is the sensible thing to do. In fact, I don't propose alternative properties to |
In the current draft description,
LabProtocol
has the propertiesbioSample
,sample
,computationalTool
,labEquipment
,reagent
.LabProcess
doesn't have any of these properties.As far as I know, this can be a problem when multiple protocol applications (ie,
LabProcess
instances) are variants of the same protocol/plan (ie, aLabProtocol
instance, linked viaexecutesLabProtocol
with n-1 cardinality), especially in the case ofbioSample
. For instance, suppose that essentially the same treatment (protocol) is administered to all the biosamples in two treatment groups, and one group uses a reagent, while the other group uses another (similar examples could be made with two versions of a software product or lab machinery).Shouldn't these properties be allowed in
LabProcess
too?Moreover, in this issue it was proposed to add
PropertyValue
to the range of such properties. In my view (and from experience with the ISA model) , having them as sub-properties ofparameterValue
(in the case ofLabProcess
) and as sub-properties of a new property named likeparameter
withFormalParameter
in the range (in the case ofLabProtocol
) would simplify searches and use cases, since often things like reagents or software names are searched in the lab parameters.bioSample
would make an exception to this, since to me, it's either aninput
/output
(in the case ofLabProtocol
) or anobject
/result
(in the case ofLabProcess
).In the latter case,
schema:Action
defines input/output with these terms, but not calling them input/output is very weird to a biologist, so I'd also makeinput
/output
sub-properties ofobject
/result
and I'd prefer these property names in the context of life science. Or, we could introduce more specific properties, such aslabProtocolInput
,labProtocolOutput
(sinceschema:input
/schema:output
are so generic names, and I'm pretty sure sooner or later they will clash with some other desired meaning in the same or another application domain, if it hasn't already happened).Finally, why does
LabProtocol
have both the propertiesbioSample
andsample
, with the same description and different ranges?The text was updated successfully, but these errors were encountered: