Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top and bottom chemicals for partition settler #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siddharthab
Copy link

@siddharthab siddharthab commented Sep 28, 2023

This can help the users specify which chemicals will definitely stay in
one of the phases and the rest will go into the other. Useful when
composing systems and you won't know everything about the composition of
the feed before simulating the complete system.

Maybe a process specification can be an alternative to this.

NOTE: There is a small breaking change in fixing a typo in the argument partion_ids to partition_ids. If you think breakage is too big for your users, I can revert the change.

  • Clear contribution

Clearly describe what the contribution is.

  • Documentation

If a new feature is added or existing functionality has changed, the documentation
should also be updated.

  • Tests

Any new or altered functionality should be tested and all tests must pass.

  • Code coverage

The code coverage should not decrease so that not unnecessary or untested code
is added.

This can help the users specify which chemicals will definitely stay in
one of the phases and the rest will go into the other. Useful when
composing systems and you won't know everything about the composition of
the feed before simulating the complete system.

Maybe a process specification can be an alternative to this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant