Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #56: count attributes on tags #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature #56: count attributes on tags #65

wants to merge 2 commits into from

Conversation

sonicaks
Copy link

  • Annotate method is used to get the count of tags

@sonicaks sonicaks mentioned this pull request Oct 14, 2019
Open
@Bhupesh-V
Copy link
Owner

Looks Good 👍
Will merge it after testing

@Animesh-Ghosh
Copy link
Collaborator

It works, but it looks like this:
image

@sonicaks
Copy link
Author

sonicaks commented Oct 26, 2019 •
edited
Loading

@Animesh-Ghosh isn't it supposed to be done like that?

@Animesh-Ghosh
Copy link
Collaborator

Maybe change some styling in the template? It looks weird otherwise.

@Bhupesh-V what do you think?

@sonicaks
Copy link
Author

@Animesh-Ghosh I don't find anything weird about it. Just an extra number denoting count was added to the tags that's all. I haven't played anything with the names of tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bhupesh-V Bhupesh-V Awaiting requested review from Bhupesh-V

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonicaks @Bhupesh-V @Animesh-Ghosh