-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jlcparts-based parts library #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of parts libraries based on data available from https://github.com/yaqwsx/jlcparts
JLC no longer (well, hasn't for a few years now) makes their entire parts library available by CSV, and the current parts table is starting to get outdated with parts no longer available or basic parts. jlcparts seems to be able to get an up-to-date library as well as do some parsing of parametric parts.
Since the data here isn't deterministic, this is strictly opt-in; all test boards will continue to be based on the included CSV. By nature this won't be as well-tested.
To use these parts:
JlcPartsBase.config_root_dir("/path/to/jlcparts-repo/web/public/data/")
so if this was done on the SMU example, it would look like:
Other changes