Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow inner connects #369

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Disallow inner connects #369

merged 3 commits into from
Jul 25, 2024

Conversation

ducky64
Copy link
Collaborator

@ducky64 ducky64 commented Jul 24, 2024 •
edited
Loading

Adds a frontend error so it doesn't result in a confusing compiler internal error.

Also fixes an unrelated type annotation issue flagged by a new version of mypy.

@ducky64 ducky64 requested a review from Suke0811 July 24, 2024 23:44
Suke0811
Suke0811 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@Suke0811 Suke0811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this

self.connect(self.conn.miso, self.mag.spi.miso)

The attempt to connect inner ports errors outs properly as follows

PolymorphicBlocks.edg.core.HdlUserExceptions.UnconnectableError: Inaccessible port: cannot connect inner ports on inner blocks

@ducky64 ducky64 merged commit 9a64eef into master Jul 25, 2024
11 checks passed
@ducky64 ducky64 deleted the connect-filter branch July 25, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Suke0811 Suke0811 Suke0811 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ducky64 @Suke0811