Automatically materialize USB and CAN mixins for compatibility #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducky64
changed the title
ducky64
changed the title
ducky64
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy code had CAN and USB on all IoControllers, but mixins changed that (because USB and CAN are not universal peripherals) which was a breaking change. This automatically materializes the USB and CAN mixins when requested using legacy-style code, by overloading
__getattr__(...). This should also correctly encode the requirement for mixins as part of the block type.Likely examples and tutorials will continue using the old-style (non-mixin) USB syntax for simplicity.