Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgconfig missing from dependencies in APT #97

Open
jeffi opened this issue Oct 17, 2022 · 3 comments · May be fixed by #112
Open

wgconfig missing from dependencies in APT #97

jeffi opened this issue Oct 17, 2022 · 3 comments · May be fixed by #112
Assignees
@zhanhugo @KDharmarajanDev

Comments

@jeffi
Copy link
Collaborator

jeffi commented Oct 17, 2022

Describe the bug
See title. Current workaround is to manually install pip install wgconfig.

To Reproduce
Steps to reproduce the behavior:

  1. Run tutorial from scratch, only apt install ros-humble-fogros2
  2. Try to run tutorial, get message about missing import for wgconfig.
@jeffi
Copy link
Collaborator Author

jeffi commented Oct 17, 2022

One solution we discussed was to vendor it.

@KDharmarajanDev KDharmarajanDev self-assigned this Oct 17, 2022
KDharmarajanDev added a commit that referenced this issue Nov 1, 2022
@KDharmarajanDev
Addresses #97 via vendoring
09b2891
SimeonOA added a commit that referenced this issue Nov 7, 2022
@SimeonOA
Merge pull request #106 from BerkeleyAutomation/wgconfig-addition
0ff7965 
Adds wgconfig locally, addressing #97

Tested on Humble Branch and works!
@KDharmarajanDev
Copy link
Collaborator

Addressed by #106

@KDharmarajanDev KDharmarajanDev mentioned this issue Nov 7, 2022
Closed
nikhiljha pushed a commit that referenced this issue Nov 7, 2022
@KDharmarajanDev
Addresses #97 via vendoring
f5b8a55 
Former-commit-id: 09b2891
nikhiljha pushed a commit that referenced this issue Nov 7, 2022
@SimeonOA
Merge pull request #106 from BerkeleyAutomation/wgconfig-addition
6c15211 
Adds wgconfig locally, addressing #97

Tested on Humble Branch and works!

Former-commit-id: 0ff7965
@SimeonOA
Copy link
Collaborator

SimeonOA commented Nov 7, 2022

Investigate Licensing on this?

@SimeonOA SimeonOA reopened this Nov 7, 2022
@zhanhugo zhanhugo linked a pull request Nov 24, 2022 that will close this issue
rudimentary custom wgconfig #112
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhanhugo zhanhugo

@KDharmarajanDev KDharmarajanDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rudimentary custom wgconfig BerkeleyAutomation/FogROS2
4 participants
@jeffi @SimeonOA @zhanhugo @KDharmarajanDev