Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Input/output port order anymore in writeTreeNodesModelXML ? #851

Open
RhysMcK opened this issue Jul 26, 2024 · 1 comment
Open

No Input/output port order anymore in writeTreeNodesModelXML ? #851

RhysMcK opened this issue Jul 26, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@RhysMcK
Copy link

RhysMcK commented Jul 26, 2024

Hi,

I notice in this commit d5ea17b you removed the input/output port ordering logic. As a result, when using writeTreeNodesModelXML() to auto-generate the <TreeNodesModel> tags for Groot2, the ports are in some ?random? order. This is than obviously reflected in Groot2 and not ideal. What was the rational behind removing this?

image

Thanks very much!

@facontidavide facontidavide self-assigned this Sep 21, 2024
@facontidavide
Copy link
Collaborator

The correct solution, in my opinion, is to presere the order of the ports as it was described in providedPorts.

Unfortunately, this means that we need to apply a change that breaks the API / ABI.

In the meantimes, can you test the changes here: #870

@facontidavide facontidavide added the enhancement New feature or request label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants