Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better failure messages for disposals test #11481

Open
PowerfulBacon opened this issue Sep 12, 2024 · 0 comments
Open

Better failure messages for disposals test #11481

PowerfulBacon opened this issue Sep 12, 2024 · 0 comments

Comments

@PowerfulBacon
Copy link
Member

Perhaps the messages for the disposals test are a bit unclear, we should concatenate failures so they look something like:

Report:
1: Chemistry: 14/57 disposal bins failed to reach chemistry. (<70%)
2. Disposal bin at (1,7,4) failed to reach 17/18 locations.
3: Engineering: 53/57 disposal bins failed to reach chemistry. (>70%)

Failures:
1: (1, 2, 3), (1, 2, 3), ...
2: ...

If some percentage of bins fail to reach a location, then it should be reported as bins failing to reach that location, otherwise it should be treated as that bin failing to reach locations.

Common faults:

  • No inputs (<20%) ever reach the desired destination and reach disposals/cargo instead: A filter doesn't exist on the network.
  • Most (>50%) inputs reach an incorrect location that isn't disposals/cargo: A filter likely exists on the network but leads to an incorrect location, or the area should be considered valid and the valid location list needs to be updated.
  • Lots (>40%) of disposal units incorrectly end up in disposals/cargo, but some (>20%) are arriving at the destination: Make sure an unsorted filter has been added as the final node in the loop before the output in disposals which leads back into the network to allow for inputs near the end of the disposals loop to pass through the entire loop.
  • A disposal unit fails to reach most (>60%) of the destinations: The disposal unit is connected to filters, but is failing to enter the disposals loop correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant