Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip based acls are case-sensitive (relevant only for ipv6) #414

Open
xschlef opened this issue Sep 19, 2019 · 2 comments
Open

ip based acls are case-sensitive (relevant only for ipv6) #414

xschlef opened this issue Sep 19, 2019 · 2 comments

Comments

@xschlef
Copy link
Contributor

xschlef commented Sep 19, 2019

the ip based acls are case sensitive:

This will deny the request, as the checks run against the lowercase ip
<Allow address="2001:DB8::5" method="*.*"/>

This will correctly allow the request
<Allow address="2001:db8::5" method="*.*"/>

@solj
Copy link
Member

solj commented Oct 14, 2019

Does https://gist.github.com/solj/d80d6aadbdf34d621c1cd0845a0b351a fix the issue for you?

@xschlef
Copy link
Contributor Author

xschlef commented Oct 15, 2019

This should fix the problem at hand, but I think a proper ipv6 handling should be implemented. Maybe using the ipaddress module?

At least parse the client ip in lowercase as well. IIRC ipv6 is completely case-insensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants