Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MixWithOthers to audio session init for iOS #917

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

James-WOC
Copy link

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix.

⤵️ What is the current behavior?

When an iOS cold-launches with this NuGet installed, it ducks/pauses the audio of any other application running in the background.

🆕 What is the new behavior (if this is a feature change)?

When an app cold-launches with this NuGet installed, it will instead mix it's audio with that of other apps in the background rather than forcing them to duck or pause.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

Use the Apple Music app to play one of it's, "Radio", streams for free. Background Apple Music and then cold launch an app with this NuGet installed and confirm the Apple Music app does not pause.

📝 Links to relevant issues/docs

#816

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants