Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds step to prepare() when calling PlayQueueItem #910

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

szurgot
Copy link

@szurgot szurgot commented Sep 22, 2023

Upgrading Windows SDK version to address version downgrade

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix.

⤵️ What is the current behavior?

When starting a queue from PlayQueueItem, the media plays, but when play is subsequently called, it restarts the queue

🆕 What is the new behavior (if this is a feature change)?

Calling pause and play now behave appropriate after starting a queue with PlayQueueItem

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

Test using an app the loads a queue then starts any item with PlayQueueItem.

📝 Links to relevant issues/docs

#856

🤔 Checklist before submitting

  • [ X ] All projects build
  • [ X ] Follows style guide lines
  • [ X ] Relevant documentation was updated
  • [ X ] Rebased onto current develop

Upgrading Windows SDK version to address version downgrade
@janwiebe-jump
Copy link
Contributor

Thanks for looking into this @szurgot
Shouldn't the change also be done here?

@szurgot
Copy link
Author

szurgot commented Oct 5, 2023

Yes. Let me fix that.

Refactors PlayQueueItem(mediaItem) to use PlayQueueItem(index) to reduce duplicated code
@szurgot
Copy link
Author

szurgot commented Oct 5, 2023

@janwiebe-jump Updated the code so that PlayQueueItem prepares in both instances. Also refactored to eliminate the duplication in those methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants