Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price override config and other upgrades #31

Open
Tritium-VLK opened this issue Dec 21, 2023 · 1 comment
Open

Price override config and other upgrades #31

Tritium-VLK opened this issue Dec 21, 2023 · 1 comment
Assignees

Comments

@Tritium-VLK
Copy link
Member

Tritium-VLK commented Dec 21, 2023

1: Abstract manual price override in events where there is no price or there is a pricing error as a config.

Config should be a json file that basically takes address/price. At best it would take address/price/price token, so you could code something in like 1 eth, or 1 bpt, or 1 anything else that does have a price.

Copy the running config into the output directory for each run so that it is clear what configuration each round ran with.

2: Add a flag for pricing problems (fail loud)
Add an additional field to the CSV that has some sort of an error flag where notice to revewers can be dropped. The throw errors like No Price and/or any other isseus that come up direclty into the CSV where they can be seen

3: Calculate based on both the TWAP price and the USD price from fee subgraph data. Add both prices + a delta in the CSV, continue to use TWAP for calculations.

@Tritium-VLK Tritium-VLK changed the title Price Override Config Price override config and other upgrades Dec 21, 2023
@Tritium-VLK
Copy link
Member Author

Additional FLAG

Note that if there are no entries or exits yield fees have not been registered. If a pool has not had an entry or exit in more than 7 days, and a flag that says "No join/exit in the last x days"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants