Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check total protocol fee for gyro pools #43

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

gosuto-inzasheru
Copy link
Member

@gosuto-inzasheru gosuto-inzasheru marked this pull request as draft October 3, 2024 09:35
@gosuto-inzasheru
Copy link
Member Author

needs BalancerMaxis/bal_addresses#450 merged first in order to test properly

@gosuto-inzasheru
Copy link
Member Author

ok ran it on top of that branch, result in core_pools.json looks great:

Screenshot 2024-10-03 at 12 54 40

@gosuto-inzasheru
Copy link
Member Author

0x46472cba35e6800012aa9fcc7939ff07478c473e00020000000000000000056c does get recognised as a core pool since it has collected protocol fees:

{
  "data": {
    "pools": [
      {
        "symbol": "ECLP-GHO-AUSDC",
        "priceRateProviders": [
          {
            "address": "0x87cd462a781c0ca843eab131bf368328848bb6fd"
          },
          {
            "address": "0x0000000000000000000000000000000000000000"
          }
        ],
        "totalLiquidity": "5524978.078679728331091983020822088",
        "protocolYieldFeeCache": null,
        "swapFee": "0.0001",
        "poolType": "GyroE",
        "poolTypeVersion": 2,
        "totalProtocolFee": "1888.157573909738882107340607911349",
        "totalProtocolFeePaidInBPT": "2184.364070426271530776"
      }
    ]
  }
}

@gosuto-inzasheru
Copy link
Member Author

this might be due to fees previously having been in place and later set to 0. we might be able to filter out such edge cases when migrating the whole query to apiv3, for now not worth it to do so on the old core subgraph

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review October 3, 2024 11:02
@gosuto-inzasheru gosuto-inzasheru merged commit aa1100c into main Oct 3, 2024
4 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the issue/bal_addresses_442 branch October 3, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle additional eCLP types for yield fee exclusion
2 participants