Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change netstandard2.0 to net48 (test) #1449

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Change netstandard2.0 to net48 (test) #1449

wants to merge 1 commit into from

Conversation

mdaneri
Copy link
Contributor

@mdaneri mdaneri commented Nov 6, 2024

Description of the Change

Change netstandard2.0 to net48

@mdaneri mdaneri marked this pull request as draft November 6, 2024 17:15
@Badgerati
Copy link
Owner

Just did some testing myself, as I had concerns about how this might affect people on Linux and PS7.0-7.2 - more so as PS7.2 is EOL this month. Seems to work, which is interesting!

Couple of questions:

  1. Any reason not to just bump this to net481? Be the most up-to-date then, and still worked in my testing as well
  2. Seeing as 2.12.0 will be going live after PS7.2 and NET6 go EOL, we probably want to remove the compiling of net6 as well. Either as a different PR, or just a part of this will do?

@mdaneri
Copy link
Contributor Author

mdaneri commented Nov 13, 2024

regarding net481 I was reading that is not working on 5.1. I haven't tried yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdaneri @Badgerati