Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename any internal function with a plural nouns to a singular one #1271

Closed
mdaneri opened this issue Mar 29, 2024 · 0 comments · Fixed by #1295
Closed

Rename any internal function with a plural nouns to a singular one #1271

mdaneri opened this issue Mar 29, 2024 · 0 comments · Fixed by #1295
Labels
enhancement ⬆️ internal-code 🔨

Comments

@mdaneri
Copy link
Contributor

mdaneri commented Mar 29, 2024

PowerShell best practices state cmdlets should use singular nouns and not plurals. Suppression allows you to suppress the rule for specific function names.
For example: Merge-PodeScriptblockArguments should be renamed to Merge-PodeScriptblockArgument
@mdaneri mdaneri mentioned this issue May 3, 2024
Closed
This was referenced May 10, 2024
Closed
Merged
@Badgerati Badgerati linked a pull request May 30, 2024 that will close this issue
Rename internal functions to be singular to align with PowerShell best practice; Add additional debug logging for some internal exceptions #1295
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in 🚀 Pode Roadmap Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ⬆️ internal-code 🔨
Projects
🚀 Pode Roadmap
Status: Done
Milestone
No milestone
2 participants
@Badgerati @mdaneri