Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

Registration Service attempts to get form from service locator when it is actually part of the form element manager #23

Open
AydinHassan opened this issue Jul 26, 2013 · 2 comments

Comments

@AydinHassan
Copy link

I was looking over the code and noticed that the registration form factory is defined in the form element manager configuration:

https://github.com/Bacon/BaconUser/blob/master/config/module.config.php#L40

However, the form registration service attempts to get the form from the service manager: https://github.com/Bacon/BaconUser/blob/master/src/BaconUser/Service/Factory/RegistrationServiceFactory.php#L31

There is no 'BaconUser\Form\RegistrationForm' key in the service manager configuration. I'm sure the form should be instantiated by the form element manager:

Like so:
$serviceLocator->get('FormElementManager')->get('BaconUser\Form\RegistrationForm')

I could be wrong and haven't tested anything, merely an observation.

@DASPRiD
Copy link
Member

DASPRiD commented Jul 27, 2013

That's probably right. We are currently working on rewriting some parts, so there may be inconsistencies right now.

@AydinHassan
Copy link
Author

Yeah sure, I just noticed and ocramius asked me to create an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants