From fb48e26b6004ca8dee5002dfaa9ca9147f6ebef9 Mon Sep 17 00:00:00 2001
From: "Julio J." <j3j5@users.noreply.github.com>
Date: Tue, 1 Oct 2024 10:51:42 -0300
Subject: [PATCH] fix(svg): generate unique IDs for gradients based on their
 properties (#187)

Closes #186
---
 src/Renderer/Image/SvgImageBackEnd.php        |  6 +-
 test/Integration/SVGRenderingTest.php         | 70 +++++++++++++++++++
 ...SVGRenderingTest__testGenericQrCode__1.svg |  2 +
 ...ntIdsForDifferentGradients__horizontal.svg |  2 +
 ...rentIdsForDifferentGradients__vertical.svg |  2 +
 5 files changed, 81 insertions(+), 1 deletion(-)
 create mode 100644 test/Integration/SVGRenderingTest.php
 create mode 100644 test/Integration/__snapshots__/files/SVGRenderingTest__testGenericQrCode__1.svg
 create mode 100644 test/Integration/__snapshots__/files/SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__horizontal.svg
 create mode 100644 test/Integration/__snapshots__/files/SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__vertical.svg

diff --git a/src/Renderer/Image/SvgImageBackEnd.php b/src/Renderer/Image/SvgImageBackEnd.php
index 227afa7..44d014e 100644
--- a/src/Renderer/Image/SvgImageBackEnd.php
+++ b/src/Renderer/Image/SvgImageBackEnd.php
@@ -316,7 +316,11 @@ private function createGradientFill(Gradient $gradient, float $x, float $y, floa
                 break;
         }
 
-        $id = sprintf('g%d', ++$this->gradientCount);
+        $toBeHashed = $this->getColorString($startColor) . $this->getColorString($endColor) . $gradient->getType();
+        if ($startColor instanceof Alpha) {
+            $toBeHashed .= (string) $startColor->getAlpha();
+        }
+        $id = sprintf('g%d-%s', ++$this->gradientCount, hash('xxh64', $toBeHashed));
         $this->xmlWriter->writeAttribute('id', $id);
 
         $this->xmlWriter->startElement('stop');
diff --git a/test/Integration/SVGRenderingTest.php b/test/Integration/SVGRenderingTest.php
new file mode 100644
index 0000000..2eb71d9
--- /dev/null
+++ b/test/Integration/SVGRenderingTest.php
@@ -0,0 +1,70 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BaconQrCodeTest\Integration;
+
+use BaconQrCode\Renderer\Color\Rgb;
+use BaconQrCode\Renderer\Image\SvgImageBackEnd;
+use BaconQrCode\Renderer\ImageRenderer;
+use BaconQrCode\Renderer\RendererStyle\EyeFill;
+use BaconQrCode\Renderer\RendererStyle\Fill;
+use BaconQrCode\Renderer\RendererStyle\Gradient;
+use BaconQrCode\Renderer\RendererStyle\GradientType;
+use BaconQrCode\Renderer\RendererStyle\RendererStyle;
+use BaconQrCode\Writer;
+use PHPUnit\Framework\Attributes\Group;
+use PHPUnit\Framework\TestCase;
+
+#[Group('integration')]
+final class SVGRenderingTest extends TestCase
+{
+    public function testGenericQrCode(): void
+    {
+        $renderer = new ImageRenderer(
+            new RendererStyle(400),
+            new SvgImageBackEnd()
+        );
+        $writer = new Writer($renderer);
+
+        $svgCode = $writer->writeString('Hello World!');
+        $expected = file_get_contents(__DIR__.'/__snapshots__/files/SVGRenderingTest__testGenericQrCode__1.svg');
+
+        $this->assertEquals($expected, $svgCode);
+    }
+
+    //    SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients_horizontal
+    //SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients_vertical
+    public function testQrWithGradientGeneratesDifferentIdsForDifferentGradients()
+    {
+        $types = ['HORIZONTAL', 'VERTICAL'];
+        foreach ($types as $type) {
+            $gradient = new Gradient(
+                new Rgb(0, 0, 0),
+                new Rgb(255, 0, 0),
+                GradientType::$type()
+            );
+            $renderer = new ImageRenderer(
+                new RendererStyle(
+                    size: 400,
+                    fill: Fill::withForegroundGradient(
+                        new Rgb(255, 255, 255),
+                        $gradient,
+                        EyeFill::inherit(),
+                        EyeFill::inherit(),
+                        EyeFill::inherit()
+                    )
+                ),
+                new SvgImageBackEnd()
+            );
+            $writer = new Writer($renderer);
+            $qr = $writer->writeString('Hello World!');
+            $expectedFile = __DIR__ . '/__snapshots__/files/';
+            $expectedFile .= 'SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__';
+            $expectedFile .= strtolower($type) . '.svg';
+            $expected = file_get_contents($expectedFile);
+
+            $this->assertEquals($expected, $qr);
+        }
+    }
+}
diff --git a/test/Integration/__snapshots__/files/SVGRenderingTest__testGenericQrCode__1.svg b/test/Integration/__snapshots__/files/SVGRenderingTest__testGenericQrCode__1.svg
new file mode 100644
index 0000000..8c8607e
--- /dev/null
+++ b/test/Integration/__snapshots__/files/SVGRenderingTest__testGenericQrCode__1.svg
@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg" version="1.1" width="400" height="400" viewBox="0 0 400 400"><rect x="0" y="0" width="400" height="400" fill="#fefefe"/><g transform="scale(13.793)"><g transform="translate(4.000,4.000)"><path fill-rule="evenodd" d="M8 0L8 1L9 1L9 2L8 2L8 5L11 5L11 4L12 4L12 3L13 3L13 0L12 0L12 3L11 3L11 2L10 2L10 0ZM9 2L9 4L11 4L11 3L10 3L10 2ZM8 6L8 7L9 7L9 8L8 8L8 9L7 9L7 8L6 8L6 9L7 9L7 10L5 10L5 9L4 9L4 8L0 8L0 10L2 10L2 11L0 11L0 13L2 13L2 11L3 11L3 13L8 13L8 14L10 14L10 15L9 15L9 17L8 17L8 21L9 21L9 19L11 19L11 21L12 21L12 19L13 19L13 21L16 21L16 20L17 20L17 19L16 19L16 18L15 18L15 17L14 17L14 18L15 18L15 19L13 19L13 17L12 17L12 16L14 16L14 15L15 15L15 16L16 16L16 15L17 15L17 18L18 18L18 19L19 19L19 18L20 18L20 16L19 16L19 15L17 15L17 14L16 14L16 13L15 13L15 12L16 12L16 10L19 10L19 12L20 12L20 14L21 14L21 12L20 12L20 11L21 11L21 8L20 8L20 10L19 10L19 8L16 8L16 9L14 9L14 8L13 8L13 9L12 9L12 12L10 12L10 9L11 9L11 6L10 6L10 7L9 7L9 6ZM12 6L12 7L13 7L13 6ZM9 8L9 9L8 9L8 10L7 10L7 11L5 11L5 10L3 10L3 11L4 11L4 12L7 12L7 11L9 11L9 9L10 9L10 8ZM14 10L14 11L13 11L13 12L12 12L12 14L11 14L11 15L13 15L13 14L14 14L14 13L13 13L13 12L15 12L15 10ZM17 11L17 12L18 12L18 11ZM8 12L8 13L9 13L9 12ZM18 13L18 14L19 14L19 13ZM10 16L10 17L9 17L9 18L10 18L10 17L11 17L11 19L12 19L12 17L11 17L11 16ZM20 19L20 20L21 20L21 19ZM18 20L18 21L19 21L19 20ZM0 0L0 7L7 7L7 0ZM1 1L1 6L6 6L6 1ZM2 2L2 5L5 5L5 2ZM21 0L14 0L14 7L21 7ZM20 1L15 1L15 6L20 6ZM19 2L16 2L16 5L19 5ZM0 21L7 21L7 14L0 14ZM1 20L6 20L6 15L1 15ZM2 19L5 19L5 16L2 16Z" fill="#000000"/></g></g></svg>
diff --git a/test/Integration/__snapshots__/files/SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__horizontal.svg b/test/Integration/__snapshots__/files/SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__horizontal.svg
new file mode 100644
index 0000000..aa79f5d
--- /dev/null
+++ b/test/Integration/__snapshots__/files/SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__horizontal.svg
@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg" version="1.1" width="400" height="400" viewBox="0 0 400 400"><rect x="0" y="0" width="400" height="400" fill="#ffffff"/><g transform="scale(13.793)"><g transform="translate(4.000,4.000)"><defs><linearGradient gradientUnits="userSpaceOnUse" x1="0" y1="0" x2="21" y2="0" id="g1-a40de6dbf9322546"><stop offset="0%" stop-color="#000000"/><stop offset="100%" stop-color="#ff0000"/></linearGradient></defs><path fill-rule="evenodd" d="M8 0L8 1L9 1L9 2L8 2L8 5L11 5L11 4L12 4L12 3L13 3L13 0L12 0L12 3L11 3L11 2L10 2L10 0ZM9 2L9 4L11 4L11 3L10 3L10 2ZM8 6L8 7L9 7L9 8L8 8L8 9L7 9L7 8L6 8L6 9L7 9L7 10L5 10L5 9L4 9L4 8L0 8L0 10L2 10L2 11L0 11L0 13L2 13L2 11L3 11L3 13L8 13L8 14L10 14L10 15L9 15L9 17L8 17L8 21L9 21L9 19L11 19L11 21L12 21L12 19L13 19L13 21L16 21L16 20L17 20L17 19L16 19L16 18L15 18L15 17L14 17L14 18L15 18L15 19L13 19L13 17L12 17L12 16L14 16L14 15L15 15L15 16L16 16L16 15L17 15L17 18L18 18L18 19L19 19L19 18L20 18L20 16L19 16L19 15L17 15L17 14L16 14L16 13L15 13L15 12L16 12L16 10L19 10L19 12L20 12L20 14L21 14L21 12L20 12L20 11L21 11L21 8L20 8L20 10L19 10L19 8L16 8L16 9L14 9L14 8L13 8L13 9L12 9L12 12L10 12L10 9L11 9L11 6L10 6L10 7L9 7L9 6ZM12 6L12 7L13 7L13 6ZM9 8L9 9L8 9L8 10L7 10L7 11L5 11L5 10L3 10L3 11L4 11L4 12L7 12L7 11L9 11L9 9L10 9L10 8ZM14 10L14 11L13 11L13 12L12 12L12 14L11 14L11 15L13 15L13 14L14 14L14 13L13 13L13 12L15 12L15 10ZM17 11L17 12L18 12L18 11ZM8 12L8 13L9 13L9 12ZM18 13L18 14L19 14L19 13ZM10 16L10 17L9 17L9 18L10 18L10 17L11 17L11 19L12 19L12 17L11 17L11 16ZM20 19L20 20L21 20L21 19ZM18 20L18 21L19 21L19 20ZM0 0L0 7L7 7L7 0ZM1 1L1 6L6 6L6 1ZM2 2L2 5L5 5L5 2ZM21 0L14 0L14 7L21 7ZM20 1L15 1L15 6L20 6ZM19 2L16 2L16 5L19 5ZM0 21L7 21L7 14L0 14ZM1 20L6 20L6 15L1 15ZM2 19L5 19L5 16L2 16Z" fill="url(#g1-a40de6dbf9322546)"/></g></g></svg>
diff --git a/test/Integration/__snapshots__/files/SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__vertical.svg b/test/Integration/__snapshots__/files/SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__vertical.svg
new file mode 100644
index 0000000..60c25da
--- /dev/null
+++ b/test/Integration/__snapshots__/files/SVGRenderingTest__testQrWithGradientGeneratesDifferentIdsForDifferentGradients__vertical.svg
@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg" version="1.1" width="400" height="400" viewBox="0 0 400 400"><rect x="0" y="0" width="400" height="400" fill="#ffffff"/><g transform="scale(13.793)"><g transform="translate(4.000,4.000)"><defs><linearGradient gradientUnits="userSpaceOnUse" x1="0" y1="0" x2="0" y2="21" id="g1-a2ca2de96657f016"><stop offset="0%" stop-color="#000000"/><stop offset="100%" stop-color="#ff0000"/></linearGradient></defs><path fill-rule="evenodd" d="M8 0L8 1L9 1L9 2L8 2L8 5L11 5L11 4L12 4L12 3L13 3L13 0L12 0L12 3L11 3L11 2L10 2L10 0ZM9 2L9 4L11 4L11 3L10 3L10 2ZM8 6L8 7L9 7L9 8L8 8L8 9L7 9L7 8L6 8L6 9L7 9L7 10L5 10L5 9L4 9L4 8L0 8L0 10L2 10L2 11L0 11L0 13L2 13L2 11L3 11L3 13L8 13L8 14L10 14L10 15L9 15L9 17L8 17L8 21L9 21L9 19L11 19L11 21L12 21L12 19L13 19L13 21L16 21L16 20L17 20L17 19L16 19L16 18L15 18L15 17L14 17L14 18L15 18L15 19L13 19L13 17L12 17L12 16L14 16L14 15L15 15L15 16L16 16L16 15L17 15L17 18L18 18L18 19L19 19L19 18L20 18L20 16L19 16L19 15L17 15L17 14L16 14L16 13L15 13L15 12L16 12L16 10L19 10L19 12L20 12L20 14L21 14L21 12L20 12L20 11L21 11L21 8L20 8L20 10L19 10L19 8L16 8L16 9L14 9L14 8L13 8L13 9L12 9L12 12L10 12L10 9L11 9L11 6L10 6L10 7L9 7L9 6ZM12 6L12 7L13 7L13 6ZM9 8L9 9L8 9L8 10L7 10L7 11L5 11L5 10L3 10L3 11L4 11L4 12L7 12L7 11L9 11L9 9L10 9L10 8ZM14 10L14 11L13 11L13 12L12 12L12 14L11 14L11 15L13 15L13 14L14 14L14 13L13 13L13 12L15 12L15 10ZM17 11L17 12L18 12L18 11ZM8 12L8 13L9 13L9 12ZM18 13L18 14L19 14L19 13ZM10 16L10 17L9 17L9 18L10 18L10 17L11 17L11 19L12 19L12 17L11 17L11 16ZM20 19L20 20L21 20L21 19ZM18 20L18 21L19 21L19 20ZM0 0L0 7L7 7L7 0ZM1 1L1 6L6 6L6 1ZM2 2L2 5L5 5L5 2ZM21 0L14 0L14 7L21 7ZM20 1L15 1L15 6L20 6ZM19 2L16 2L16 5L19 5ZM0 21L7 21L7 14L0 14ZM1 20L6 20L6 15L1 15ZM2 19L5 19L5 16L2 16Z" fill="url(#g1-a2ca2de96657f016)"/></g></g></svg>