Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @testing-library/jest-dom to v6 #198

Closed
wants to merge 2 commits into from

Conversation

BacLuc
Copy link
Owner

@BacLuc BacLuc commented Aug 22, 2023

This PR contains the following updates:

Package Type Update Change
@testing-library/jest-dom devDependencies major 5.17.0 -> 6.0.1

Release Notes

testing-library/jest-dom (@​testing-library/jest-dom)

v6.0.1

Compare Source

Bug Fixes
  • matchers type is making the global expect unsafe (#​513) (bdb34f1)

v6.0.0

Compare Source

Features
BREAKING CHANGES
  • Removes the extend-expect script. Users should use
    the default import path or one of the new test platform-specific
    paths to automatically extend the appropriate "expect" instance.

extend-expect was not documented in the Readme, so this change should
have minimal impact.

Users can now use the following import paths to automatically extend
"expect" for their chosen test platform:

For example:

import '@​testing-library/jest-dom/jest-globals'

Importing from one of the above paths will augment the appropriate
matcher interface for the given test platform, assuming the import
is done in a .ts file that is included in the user's tsconfig.json.

It's also (still) possible to import the matchers directly without
side effects:

import * as matchers from '@​testing-library/jest-dom/matchers'

  • Update kcd-scripts
  • Drop node < 14

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

From commit 9b34417.
One commit before this still worked, with commit 9b34417 the dev mode is broken.
Nuxt 2 clashes with the new prettier, thus we stay at prettier v2.
Also add package rules for print/package.json for these 2 packages.
Also revert the format changes from 5585942.

Else we have the following error for all vue templates when running npm run dev:
ecamp3-print  | > 1 | [object Promise]
ecamp3-print  |     |         ^
ecamp3-print  |   2 | export { render, staticRenderFns }
ecamp3-print  |     at parser.next (<anonymous>)
ecamp3-print  |     at normalizeFile.next (<anonymous>)
ecamp3-print  |     at run.next (<anonymous>)
ecamp3-print  |     at transform.next (<anonymous>)
ecamp3-print  |
ecamp3-print  |
ecamp3-print  | [log] [friendly-errors]
ecamp3-print  |  @ ./pages/index.vue?vue&type=template&id=2a183b29& 1:0-290 1:0-290
ecamp3-print  |  @ ./pages/index.vue
ecamp3-print  |  @ ./.nuxt/router.js
ecamp3-print  |  @ ./.nuxt/index.js
ecamp3-print  |  @ ./.nuxt/client.js
ecamp3-print  |  @ multi ./node_modules/eventsource-polyfill/dist/browserify-eventsource.js (webpack)-hot-middleware/client.js?reload=true&timeout=30000&ansiColors=&overlayStyles=&path=%2F__webpack_hmr%2Fclient&name=client ./.nuxt/client.js
@BacLuc
Copy link
Owner Author

BacLuc commented Aug 22, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: frontend/package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   jest@"^27.1.0" from @vue/[email protected]
npm ERR!   node_modules/@vue/cli-plugin-unit-jest
npm ERR!     dev @vue/cli-plugin-unit-jest@"5.0.8" from the root project
npm ERR!   peer jest@"27.x" from @vue/[email protected]
npm ERR!   node_modules/@vue/vue2-jest
npm ERR!     dev @vue/vue2-jest@"27.0.0" from the root project
npm ERR!     peerOptional @vue/vue2-jest@"^27.0.0-alpha.3" from @vue/[email protected]
npm ERR!     node_modules/@vue/cli-plugin-unit-jest
npm ERR!       dev @vue/cli-plugin-unit-jest@"5.0.8" from the root project
npm ERR!   1 more (jest-watch-typeahead)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! dev @testing-library/jest-dom@"6.0.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/jest
npm ERR!   peerOptional jest@">= 28" from @testing-library/[email protected]
npm ERR!   node_modules/@testing-library/jest-dom
npm ERR!     dev @testing-library/jest-dom@"6.0.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-08-22T14_45_18_593Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-08-22T14_45_18_593Z-debug-0.log

@BacLuc
Copy link
Owner Author

BacLuc commented Nov 7, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 6.x releases. But if you manually upgrade to 6.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@BacLuc BacLuc deleted the renovate/testing-library-jest-dom-6.x branch November 7, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant