Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show GLSL errors / warnings in the shader editor #279

Closed
JannikGM opened this issue Aug 23, 2023 · 2 comments
Closed

Show GLSL errors / warnings in the shader editor #279

JannikGM opened this issue Aug 23, 2023 · 2 comments

Comments

@JannikGM
Copy link
Contributor

There should be an option to display GLSL errors and warnings in the editor.
Ideally, this would be shown in the respective lines.

The underlying editor supports this: https://mkslanc.github.io/ace-playground/#providing-custom-annotations
There's also some parser for GLSL errors / warnings in luma.gl that could be repurposed.

This is especially relevant after fixing #278; ideally, gl.getShaderInfoLog or gl.compileShader (and respective gl.linkProgram etc.) would also allow to jump to the editor (which could include said annotations).

@JannikGM
Copy link
Contributor Author

There's also some parser for GLSL errors / warnings in luma.gl that could be repurposed.

Looks like parsing the messages is trivial: https://github.com/visgl/luma.gl/blob/b9194eeee698868cdaee87b28f2992f150a61ae1/modules/webgl/src/adapter/helpers/parse-shader-compiler-log.ts

I thought the format would be much less consistent.

@sebavan
Copy link
Member

sebavan commented Aug 30, 2023

closing in favor of #283

Spector has never been thought as a tool to help during shader development and it would be great to enhance this area.

@sebavan sebavan closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants