Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDB for Windows NPM releases #453

Closed
CedricGuillemet opened this issue Aug 31, 2022 · 1 comment
Closed

PDB for Windows NPM releases #453

CedricGuillemet opened this issue Aug 31, 2022 · 1 comment
Milestone

Comments

@CedricGuillemet
Copy link
Contributor

.pdb are not present in BRN npm for Windows.
I guess it's a choice or npm would be >500Mb.
You have to build BRN locally and copy .lib/.pdb manually if you need to debug.

We need .pdb to be present somehow so it's easier for the dev team or users/contributor to test and debug.

I have 2 proposals to achieve this:

  • Improve the build system/npm so NPM will not contain everything but it will only download at installation time a sub-package. I talked briefly with @RaananW about that. I think it's the way to go but it needs a lot of work and testing. This way, we are not tight to the 200Mb limit.
  • Provide the .pdb as a downloadable artifact. Easier to do but you have to be logged in Github to be able to download them. Moreover, you will have to go the the action corresponding to the npm publishing, donwload an unzip it manually. The artifact are retained for 90days.
@thomlucc thomlucc added the 6.0 label Sep 23, 2022
@thomlucc thomlucc added this to the 6.0 milestone Sep 23, 2022
@thomlucc thomlucc removed the 6.0 label Sep 23, 2022
@bghgary bghgary modified the milestones: 6.0, Future Dec 1, 2022
@bghgary
Copy link
Contributor

bghgary commented Sep 10, 2024

We would probably fix this by putting pdbs into separate packages. Closing in favor of #614

@bghgary bghgary closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants