From 1620af414622216fe48922ab2cd3a8805fcb8ce3 Mon Sep 17 00:00:00 2001 From: Raanan Weber Date: Thu, 2 May 2024 18:13:34 +0200 Subject: [PATCH 1/3] The disposed engine needs to be the thinengine --- packages/dev/core/src/Misc/dumpTools.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/dev/core/src/Misc/dumpTools.ts b/packages/dev/core/src/Misc/dumpTools.ts index f92c9b3203c..1b97ac27e09 100644 --- a/packages/dev/core/src/Misc/dumpTools.ts +++ b/packages/dev/core/src/Misc/dumpTools.ts @@ -52,8 +52,8 @@ export class DumpTools { EngineStore.OnEnginesDisposedObservable.add((e) => { // guaranteed to run when no other instances are left // only dispose if it's not the current engine - if (e !== engine && !e.isDisposed) { - e.dispose(); + if (e !== engine && !engine.isDisposed) { + engine.dispose(); } }); engine.getCaps().parallelShaderCompile = undefined; From b829e947419a50454e2285735386bff82cc56534 Mon Sep 17 00:00:00 2001 From: Raanan Weber Date: Thu, 2 May 2024 18:30:08 +0200 Subject: [PATCH 2/3] oh, typescript... --- packages/dev/core/src/Misc/dumpTools.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dev/core/src/Misc/dumpTools.ts b/packages/dev/core/src/Misc/dumpTools.ts index 1b97ac27e09..5d1b27831a6 100644 --- a/packages/dev/core/src/Misc/dumpTools.ts +++ b/packages/dev/core/src/Misc/dumpTools.ts @@ -52,7 +52,7 @@ export class DumpTools { EngineStore.OnEnginesDisposedObservable.add((e) => { // guaranteed to run when no other instances are left // only dispose if it's not the current engine - if (e !== engine && !engine.isDisposed) { + if (engine && e !== engine && !engine.isDisposed) { engine.dispose(); } }); From 5ae4771c42d124aa87769ae4ffb33ff71c0e2334 Mon Sep 17 00:00:00 2001 From: Raanan Weber Date: Fri, 3 May 2024 15:22:14 +0200 Subject: [PATCH 3/3] Not reproducible locally on any device. --- packages/tools/tests/test/visualization/config.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/tools/tests/test/visualization/config.json b/packages/tools/tests/test/visualization/config.json index d927d5a9cb5..ed7c262e543 100644 --- a/packages/tools/tests/test/visualization/config.json +++ b/packages/tools/tests/test/visualization/config.json @@ -787,12 +787,14 @@ { "title": "GLTF Serializer Morph Target Animation Group", "playgroundId": "#T087A8#29", - "referenceImage": "gltfSerializerMorphTargetAnimationGroup.png" + "referenceImage": "gltfSerializerMorphTargetAnimationGroup.png", + "excludedEngines": ["webgl1"] }, { "title": "GLTF Serializer KHR materials clearcoat", "playgroundId": "#9N6CLU#23", - "referenceImage": "glTFSerializerKhrMaterialsClearcoat.png" + "referenceImage": "glTFSerializerKhrMaterialsClearcoat.png", + "excludedEngines": ["webgl1"] }, { "title": "GLTF Serializer KHR gpu instancing",