Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc 8.3 compilation warnings #14

Open
pinkenburg opened this issue Oct 5, 2020 · 1 comment
Open

gcc 8.3 compilation warnings #14

pinkenburg opened this issue Oct 5, 2020 · 1 comment

Comments

@pinkenburg
Copy link
Contributor

Three sources give warnings when compiled with gcc 8.3 and std=c++17:

src/simulator.cpp:769:90: warning: narrowing conversion of 'row' from 'unsigned int' to 'int' inside { } [-Wnarrowing]
StTpcLocalSectorCoordinate xyzW{at_readout.x, at_readout.y, at_readout.z, sector, row};

test/test_tpcrs.cpp:45:84: warning: no return statement in function returning non-void [-Wreturn-type]
Diff& operator +=(const Diff& b) { total += b.total; unmatched += b.unmatched; }

include/tpcrs/detail/digitizer.h:145:1: warning: no return statement in function returning non-void [-Wreturn-type]

@pinkenburg
Copy link
Contributor Author

simulator.cpp warning is fixed in my PR #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant