Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mincbbox: wrong step extent for non 1.0 step sizes #20

Open
gdevenyi opened this issue Jan 7, 2017 · 0 comments
Open

mincbbox: wrong step extent for non 1.0 step sizes #20

gdevenyi opened this issue Jan 7, 2017 · 0 comments

Comments

@gdevenyi
Copy link
Contributor

gdevenyi commented Jan 7, 2017

Another issue is that it returns by default the wrong extent if the step
is not 1mm:

if (two_lines)
print ("%f %f %f\n%f %f %f\n",minx, miny, minz, maxx-minx+1, maxy-miny+1,
maxz-minz+1);
else
print ("%f %f %f %f %f %f\n",minx, miny, minz, maxx-minx+1, maxy-miny+1,
maxz-minz+1);

"max{x,y,z}-min{x,y,z}+1" should probably be replaced by
"max{x,y,z}-min{x,y,z}+step{x,y,z}" to report the extent of the voxel
dimensions (edge to edge) in world coordinates as I think is intended or
simply "max{x,y,z}-min{x,y,z}" to report the extent between the voxel
centers.

Reported on mailing list:
http://www.bic.mni.mcgill.ca/pipermail/minc-users/2017-January/004589.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant