Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a Loadcase does not have an AdapterId the Create crashes #392

Open
peterjamesnugent opened this issue Jan 4, 2024 · 0 comments
Open

When a Loadcase does not have an AdapterId the Create crashes #392

peterjamesnugent opened this issue Jan 4, 2024 · 0 comments
Labels
type:bug Error or unexpected behaviour

Comments

@peterjamesnugent
Copy link
Member

peterjamesnugent commented Jan 4, 2024 •
edited
Loading

Description:

Quite a niche case when the Loadcase.Number is the same, but the names are different. The name is reassigned but the AdapterId is not.

Steps to reproduce:

See test script.

Expected behaviour:

The AdapterId should be assigned, there should also be a check downstream that looks at the AdapterId and the LoadcaseId if they do not exist, to return an error rather than exception.

Test file(s):

https://burohappold.sharepoint.com/:f:/s/BHoM/Eghq8HuCT3FLvUSO992AdQQBT_SYE8jGp24vlmoyyF6VRw?e=yY7zYe
@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Jan 4, 2024
@peterjamesnugent peterjamesnugent mentioned this issue Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterjamesnugent