Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialiser_Engine: Investigate edge case where the Serialiser_Engine is able to deserialise methods with changed method signature #3310

Open
IsakNaslundBh opened this issue Mar 4, 2024 · 0 comments
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

https://github.com/BHoM/BHoM_Engine/pull/3309/files shows that the Serialiser_Engien is able to deserialise and implicitly upgrade the methods even if it has a changed method signature. For the particular case, it upgrades correctly, but for the general case this could be an issue if it upgrades to something it is not meant to upgrade to. All changes to method signature should be handled explicitly in versioning and this type of upgrade by chance should not really be happening.

For the current case it might have to do with input type being changed between "Timber" and "ITimber", and the fact that we sometimes remove the leading I in the ToText method for types, but is to be investigated.

Steps to reproduce:

Expected behaviour:

Test file(s):

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Mar 4, 2024
@FraserGreenroyd FraserGreenroyd removed their assignment Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

2 participants