You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
https://github.com/BHoM/BHoM_Engine/pull/3309/files shows that the Serialiser_Engien is able to deserialise and implicitly upgrade the methods even if it has a changed method signature. For the particular case, it upgrades correctly, but for the general case this could be an issue if it upgrades to something it is not meant to upgrade to. All changes to method signature should be handled explicitly in versioning and this type of upgrade by chance should not really be happening.
For the current case it might have to do with input type being changed between "Timber" and "ITimber", and the fact that we sometimes remove the leading I in the ToText method for types, but is to be investigated.
Steps to reproduce:
Expected behaviour:
Test file(s):
The text was updated successfully, but these errors were encountered:
Description:
https://github.com/BHoM/BHoM_Engine/pull/3309/files shows that the Serialiser_Engien is able to deserialise and implicitly upgrade the methods even if it has a changed method signature. For the particular case, it upgrades correctly, but for the general case this could be an issue if it upgrades to something it is not meant to upgrade to. All changes to method signature should be handled explicitly in versioning and this type of upgrade by chance should not really be happening.
For the current case it might have to do with input type being changed between "Timber" and "ITimber", and the fact that we sometimes remove the leading I in the ToText method for types, but is to be investigated.
Steps to reproduce:
Expected behaviour:
Test file(s):
The text was updated successfully, but these errors were encountered: