Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7 Change app name - running just fine #8

Merged
merged 2 commits into from
Jun 14, 2024
Merged

#7 Change app name - running just fine #8

merged 2 commits into from
Jun 14, 2024

Conversation

rodolakis
Copy link
Collaborator

@rodolakis rodolakis commented Jun 14, 2024 •
edited
Loading

@rodolakis rodolakis self-assigned this Jun 14, 2024
@rodolakis rodolakis added the task routine work label Jun 14, 2024
@prjemian
Copy link
Collaborator

I'm seeing two branches now:

image

@prjemian
Copy link
Collaborator

The second one (with the # in the name), is the extra one. Can remove it.

@prjemian
Copy link
Collaborator

No qsui found now:

(bluesky_2024_2) prjemian@arf:~/.../BCDA-APS/queueUI$ git branch
* #7-change-project-name
  main
(bluesky_2024_2) prjemian@arf:~/.../BCDA-APS/queueUI$ git pull
Already up to date.
(bluesky_2024_2) prjemian@arf:~/.../BCDA-APS/queueUI$ git grep -i qsui
(bluesky_2024_2) prjemian@arf:~/.../BCDA-APS/queueUI$

@prjemian
Copy link
Collaborator

After pip install, started app locally with command: python -m queueUI.app &

@prjemian
Copy link
Collaborator

Request About ... from the ? menu crashes the app.

@prjemian prjemian mentioned this pull request Jun 14, 2024
Open
@prjemian
Copy link
Collaborator

Menu File -> Exit works successfully. Other File menu items are no-op but do not crash the app.

prjemian
prjemian approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Passes my simple tests, as noted.

@prjemian prjemian mentioned this pull request Jun 14, 2024
Open
@rodolakis
Copy link
Collaborator Author

I'm seeing two branches now:

image

yep I just messed up when creating a new branch

@rodolakis rodolakis merged commit 9d45a5a into main Jun 14, 2024
1 check passed
@rodolakis rodolakis deleted the #7-change-project-name branch June 14, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian prjemian approved these changes

@MDecarabas MDecarabas Awaiting requested review from MDecarabas

@olliviergassant olliviergassant Awaiting requested review from olliviergassant

Assignees

@rodolakis rodolakis

Labels
task routine work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change app name
2 participants
@rodolakis @prjemian