Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update official CCA samples to Node v2 #7038

Closed
10 tasks done
bgavrilMS opened this issue Apr 18, 2024 · 0 comments · Fixed by Azure-Samples/ms-identity-javascript-nodejs-console#14, Azure-Samples/ms-identity-javascript-nodejs-tutorial#128 or Azure-Samples/ms-identity-ciam-javascript-tutorial#82
Closed
10 tasks done

Update official CCA samples to Node v2 #7038

bgavrilMS opened this issue Apr 18, 2024 · 0 comments · Fixed by Azure-Samples/ms-identity-javascript-nodejs-console#14, Azure-Samples/ms-identity-javascript-nodejs-tutorial#128 or Azure-Samples/ms-identity-ciam-javascript-tutorial#82
Assignees
@Robbie-Microsoft
Labels
bug A problem that needs to be fixed for the feature to function as intended. confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months.

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Apr 18, 2024 •
edited by Robbie-Microsoft
Loading

Core Library

MSAL Node (@azure/msal-node)

Wrapper Library

Not Applicable

Public or Confidential Client?

Confidential

Description

Ensure the NodeJS official CCA samples are up to date with MSAL Node. Most use msal v1. I recommend deleting the package.json.lock files to ensure samples always reference the latest version.

CIAM

AAD

B2C - do NOT update B2C samples.

Source

Internal (Microsoft)
@bgavrilMS bgavrilMS added question Customer is asking for a clarification, use case or information. feature-unconfirmed labels Apr 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Apr 18, 2024
@github-actions github-actions bot added confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package labels Apr 18, 2024
@bgavrilMS bgavrilMS added bug A problem that needs to be fixed for the feature to function as intended. feature Feature requests. p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months. and removed question Customer is asking for a clarification, use case or information. msal-node Related to msal-node package Needs: Attention 👋 Awaiting response from the MSAL.js team feature-unconfirmed feature Feature requests. labels Apr 18, 2024
@github-actions github-actions bot added the msal-node Related to msal-node package label Apr 18, 2024
This was linked to pull requests May 1, 2024
Updated MSAL-Node from v1.x -> v2.x Azure-Samples/ms-identity-javascript-nodejs-console#14
Merged
Updated MSAL-Node from v1.x -> v2.x Azure-Samples/ms-identity-javascript-nodejs-tutorial#128
Merged
@Robbie-Microsoft Robbie-Microsoft linked a pull request May 10, 2024 that will close this issue
Updated MSAL-Node from v1.x -> v2.x Azure-Samples/ms-identity-ciam-javascript-tutorial#82
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Robbie-Microsoft Robbie-Microsoft

Labels
bug A problem that needs to be fixed for the feature to function as intended. confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months.
Projects
None yet
Milestone
No milestone
2 participants
@bgavrilMS @Robbie-Microsoft