Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply fix for multiple_cached_tokens to OBO and client_creds #6507

Closed
bgavrilMS opened this issue Sep 22, 2023 · 1 comment
Closed

Apply fix for multiple_cached_tokens to OBO and client_creds #6507

bgavrilMS opened this issue Sep 22, 2023 · 1 comment
Labels
bug A problem that needs to be fixed for the feature to function as intended. confidential-client Issues regarding ConfidentialClientApplications p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months.

Comments

@bgavrilMS
Copy link
Member

Core Library

MSAL Node (@azure/msal-node)

Core Library Version

2.0

Wrapper Library

Not Applicable

Wrapper Library Version

2

Public or Confidential Client?

Confidential

Description

This is a follow up for the fix https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/6311/files

Looks like MSAL can get into a bad "cache" state. This was fixed for auth_code flow and for PCA via SilentAuth code path. The "fix" should be applied to OBO and client_creds as well.

Error Message

a

Msal Logs

a

MSAL Configuration

CCA

Relevant Code Snippets

no

Reproduction Steps

no

Expected Behavior

no error

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

None (Server)

Regression

no

Source

Internal (Microsoft)
@bgavrilMS bgavrilMS added question Customer is asking for a clarification, use case or information. bug-unconfirmed A reported bug that needs to be investigated and confirmed labels Sep 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Sep 22, 2023
@bgavrilMS bgavrilMS added bug A problem that needs to be fixed for the feature to function as intended. p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months. and removed question Customer is asking for a clarification, use case or information. bug-unconfirmed A reported bug that needs to be investigated and confirmed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Sep 22, 2023
@github-actions github-actions bot added confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package labels Sep 22, 2023
@bgavrilMS bgavrilMS removed the msal-node Related to msal-node package label Sep 22, 2023
@bgavrilMS
Copy link
Member Author

Not sure a fix is needed, but we need a test with a cache file using MSAL 1.10 and then to be used with latests MSAL>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem that needs to be fixed for the feature to function as intended. confidential-client Issues regarding ConfidentialClientApplications p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bgavrilMS @jo-arroyo @Robbie-Microsoft