Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Engineering Task] Missing XML comment for publicly visible type or member #4244

Closed
Tracked by #4200 ...
gladjohn opened this issue Jul 13, 2023 · 3 comments
Closed
Tracked by #4200 ...

Comments

@gladjohn
Copy link
Contributor

Warnings from Build https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1133749&view=logs&j=15dfcb1a-0989-5cf6-3160-3e181e44de87&t=cdee0a61-8978-5bd6-7f9d-8251f4e5ad03&l=33

##[warning]microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(47,21): Warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.IsSystemWebViewAvailable'
C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(47,21): warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.IsSystemWebViewAvailable' [C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\Microsoft.Identity.Client.csproj]
##[warning]microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(101,56): Warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenInteractive(IEnumerable<string>)'
C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(101,56): warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenInteractive(IEnumerable<string>)' [C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\Microsoft.Identity.Client.csproj]
##[warning]microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(109,59): Warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenWithDeviceCode(IEnumerable<string>, Func<DeviceCodeResult, Task>)'
C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(109,59): warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenWithDeviceCode(IEnumerable<string>, Func<DeviceCodeResult, Task>)' [C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\Microsoft.Identity.Client.csproj]
##[warning]microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(129,68): Warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenByIntegratedWindowsAuth(IEnumerable<string>)'
C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(129,68): warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenByIntegratedWindowsAuth(IEnumerable<string>)' [C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\Microsoft.Identity.Client.csproj]
##[warning]microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(139,63): Warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenByUsernamePassword(IEnumerable<string>, string, SecureString)'
C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(139,63): warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenByUsernamePassword(IEnumerable<string>, string, SecureString)' [C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\Microsoft.Identity.Client.csproj]
##[warning]microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(151,63): Warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenByUsernamePassword(IEnumerable<string>, string, string)'
C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\PublicClientApplication.cs(151,63): warning CS1591: Missing XML comment for publicly visible type or member 'PublicClientApplication.AcquireTokenByUsernamePassword(IEnumerable<string>, string, string)' [C:\__w\1\s\microsoft-authentication-library-for-dotnet\src\client\Microsoft.Identity.Client\Microsoft.Identity.Client.csproj]
  CompilerServer: server - server processed compilation - 9bcaa058-9ee9-4622-9975-7012758ed1e9

@gladjohn
Copy link
Contributor Author

like this one here :

public bool IsSystemWebViewAvailable // TODO MSAL5: consolidate these helpers in the interface

@pmaytak
Copy link
Contributor

pmaytak commented Aug 4, 2023

I think I ended up fixing these in #4284.

@localden
Copy link
Collaborator

localden commented Aug 4, 2023

Yeah, #4287 ended up covering some extras too. Thanks for the heads-up @pmaytak!

@pmaytak pmaytak closed this as completed Aug 22, 2023
@pmaytak pmaytak modified the milestones: 4.57.0, 4.56.0 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants