Management Group Diagnostic Settings recreated every deployment

[robsissons-contino]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: 1.9.5

azure provider: 3.116.0

module: 6.1.0

Description

Describe the bug

diagnostic settings deployed for management groups as part of the core module, using the variable "deploy_diagnostics_for_mg" are constantly destroyed and recreated.

Often the recreation of these resources will fail causing the pipeline to fail and requiring another deployment to resolve.

Steps to Reproduce

1. Deploy CORE module with the "deploy_diagnostics_for_mg" variable set to true
2. push an update
3. plan / apply will remove and attempt to recreate the resources
4. Often the recreation will fail due no sleep between actions

Screenshots

Additional context

This appears to be related to a long outstanding issue with the location field on diagnostic settings which are created through azapi -

Azure/terraform-provider-azapi#511

A possible solution/workaround appears to be to set a location ('global') for the resource to avoid the recreation ?