-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Race condition results in InternalServerError when deploying in vhub a firewall, an express route gateway, vhub peering and routing intent #1135
Labels
Comments
Thank you @LaurentLesle |
LaurentLesle
added a commit
to LaurentLesle/terraform-azurerm-caf-enterprise-scale
that referenced
this issue
Sep 19, 2024
matt-FFFFFF
pushed a commit
that referenced
this issue
Nov 13, 2024
<!-- markdownlint-disable first-line-h1 --> <!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary Replace this with a brief description of what this Pull Request fixes, changes, etc. ## This PR fixes/adds/changes/removes 1. Fixes #1135 - Race condition results in InternalServerError when deploying in vhub a firewall, an express route gateway, vhub peering and routing intent 2. Fixes #1136 - Updating existing vnet dns_server with Azure firewall leads to azurerm_virtual_network error. 3. *Replace me* ### Breaking Changes none ## Testing Evidence ``` module.alz_connectivity.azurerm_virtual_hub_routing_intent.virtual_wan["/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/lz-cl-routingintent-southeastasia"]: Still creating... [6m40s elapsed] module.alz_connectivity.azurerm_virtual_hub_routing_intent.virtual_wan["/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/lz-cl-routingintent-southeastasia"]: Creation complete after 6m41s [id=/subscriptions/000000/resourceGroups/rg-prod-network-vwan/providers/Microsoft.Network/virtualHubs/lz-cl-hub-southeastasia/routingIntent/lz-cl-routingintent-southeastasia] Apply complete! Resources: 178 added, 0 changed, 0 destroyed. ``` Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate). ## As part of this Pull Request I have - [x] Checked for duplicate [Pull Requests](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pulls) - [x] Associated it with relevant [issues](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues), for tracking and closure. - [x] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/tree/main) - [x] Performed testing and provided evidence. - [x] Updated relevant and associated documentation.
Released in v6.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Community Note
Versions
terraform: 1.9.4
azure provider: 3.108.0
module: 6.1.0
Description
Describe the bug
When deploying the virtual hub connectivity services with an Azure firewall, an express route gateway, routing intent and vhub connections the deployment ends-up with an InternalServerError and deployment time and destroy time.
Steps to Reproduce
enable vwan
enable vhub
enable firewall (secure hub)
enable routing intent
peer existing vnets to the hub
apply
Screenshots
Additional context
By adding a depends_on azurerm_express_route_gateway.virtual_wan to the azurerm_virtual_hub_connection and azurerm_virtual_hub_routing_intent I managed to fix the deploy and destroy issues described above.
I am going to submit the PR.
The text was updated successfully, but these errors were encountered: