From 45318e363ac3ae6678916017cd1aa3513b7e08cb Mon Sep 17 00:00:00 2001 From: Greg Slack Date: Tue, 23 Apr 2024 15:34:26 -0400 Subject: [PATCH] Including Heinrich's changes --- Scripts/Helpers/Build-AssignmentDefinitionAtLeaf.ps1 | 12 ++++-------- Scripts/Helpers/Confirm-PolicyResourceExclusions.ps1 | 8 ++++---- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/Scripts/Helpers/Build-AssignmentDefinitionAtLeaf.ps1 b/Scripts/Helpers/Build-AssignmentDefinitionAtLeaf.ps1 index b987fc82..8d7a3e21 100644 --- a/Scripts/Helpers/Build-AssignmentDefinitionAtLeaf.ps1 +++ b/Scripts/Helpers/Build-AssignmentDefinitionAtLeaf.ps1 @@ -48,7 +48,7 @@ function Build-AssignmentDefinitionAtLeaf { $nonComplianceMessages = $AssignmentDefinition.nonComplianceMessages $hasPolicySets = $AssignmentDefinition.hasPolicySets $perEntryNonComplianceMessages = $AssignmentDefinition.perEntryNonComplianceMessages - + $flatPolicyList = $AssignmentDefinition.flatPolicyList $thisPacOwnerId = $PacEnvironment.pacOwnerId #endregion cache frequently used fields @@ -516,10 +516,6 @@ function Build-AssignmentDefinitionAtLeaf { $parameterObject = $null $parametersInPolicyDefinition = @{} - if ($displayName -eq "Allowed Locations") { - $null = $null - } - if ($isPolicySet) { $parametersInPolicyDefinition = $policySetDetails.parameters if ($useCsv) { @@ -591,9 +587,9 @@ function Build-AssignmentDefinitionAtLeaf { if ($RoleDefinitions.ContainsKey($roleDefinitionId)) { $roleDisplayName = $RoleDefinitions.$roleDefinitionId } - else { - $null = $null - } + # else { + # $null = $null + # } $requiredRoleAssignment = @{ scope = $scopeEntry.scope roleDefinitionId = $roleDefinitionId diff --git a/Scripts/Helpers/Confirm-PolicyResourceExclusions.ps1 b/Scripts/Helpers/Confirm-PolicyResourceExclusions.ps1 index bbfc55d4..f015f0e4 100644 --- a/Scripts/Helpers/Confirm-PolicyResourceExclusions.ps1 +++ b/Scripts/Helpers/Confirm-PolicyResourceExclusions.ps1 @@ -33,10 +33,10 @@ function Confirm-PolicyResourceExclusions { if ($null -ne $PolicyResourceTable) { $PolicyResourceTable.counters.excluded += 1 } - if ($resourceIdParts.kind -eq "policyAssignments") { - $excludedScope = $ExcludedScopesTable.$scope - $null = $null - } + # if ($resourceIdParts.kind -eq "policyAssignments") { + # $excludedScope = $ExcludedScopesTable.$scope + # $null = $null + # } return $false, $resourceIdParts } foreach ($testExcludedId in $ExcludedIds) {