Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-core-tracing: support setting error status on spans #37093

Open
lmolkova opened this issue Aug 29, 2024 · 0 comments
Open

azure-core-tracing: support setting error status on spans #37093

lmolkova opened this issue Aug 29, 2024 · 0 comments
Labels
OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

lmolkova commented Aug 29, 2024

There is no way to set status on span, we need to add a method that would be able to:

  • take exception or string as an input parameters
  • set span status, description and error.type attribute

in otel implementation:

If exception is passed:

  • set status code to error
  • set status description to exception message
  • use exception fully qualified name to set error.type attribute

If error string is passed:

  • set status code to error
  • set status description and error.type to error string

We never report status for successful spans (and unlikely to ever need it), so we might as well limit the scope of this method to reporting errors.

Related: #36890 (comment)

@lmolkova lmolkova added the OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) label Aug 29, 2024
@lmolkova lmolkova changed the title azure-core-tracing: support setting status on spans azure-core-tracing: support setting error status on spans Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Development

No branches or pull requests

1 participant