From 46c84e3a3f1bc6c6f32c9892e94324a05009b232 Mon Sep 17 00:00:00 2001
From: Ahson Khan <ahson_ahmedk@yahoo.com>
Date: Wed, 7 Apr 2021 14:41:12 -0700
Subject: [PATCH] Update the Azure.Core changelog to be more consise and
 complete for the beta.8 (#2069)

* Update the Azure.Core changelog to be more consise and complete for the beta.8
release.

* Fix the new feature section since `GetDeadline` was added this release.

* Add note about types moving between header files.

* Make identity related fixes.

Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
---
 sdk/core/azure-core/CHANGELOG.md         | 32 +++++++++++++++---------
 sdk/identity/azure-identity/CHANGELOG.md |  4 +++
 2 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md
index ede10c20aa..9c83b3d17b 100644
--- a/sdk/core/azure-core/CHANGELOG.md
+++ b/sdk/core/azure-core/CHANGELOG.md
@@ -6,33 +6,42 @@
 
 - Added `Azure::Core::Url::GetScheme()`.
 - Added `Azure::Core::Context::TryGetValue()`.
+- Added `Azure::Core::Context::GetDeadline()`.
+- Added `Azure::Core::Credentials::TokenCredentialOptions`.
+- Added useful fields to the `Azure::Core::RequestFailedException` class such as `StatusCode`, `ReasonPhrase`, and the `RawResponse`, for better diagnosis of errors.
 
 ### Breaking Changes
 
 - Simplified the `Response<T>` API surface to expose two public fields with direct access: `T Value` and a `unique_ptr` to an `Azure::Core::Http::RawResponse`.
+- Renamed `Azure::Nullable<T>::GetValue()` to `Value()`.
 - Removed from `Azure::Core::Http::Request`:
   - `SetUploadChunkSize()`.
   - `GetHTTPMessagePreBody()`.
   - `GetUploadChunkSize()`.
-- Removed from `Azure::Core::Http::RawResponse`:
-  - `SetHeader(std::string const& header)`
-  - `SetHeader(uint8_t const* const first, uint8_t const* const last)`.
-  - `GetMajorVersion()`.
-  - `GetMinorVersion()`.
-- Renamed `Azure::Nullable<T>::GetValue()` to `Value()`.
+  - `GetHeadersAsString()`.
+- Changes to `Azure::Core::Http::RawResponse`:
+  - Removed `SetHeader(std::string const& header)`
+  - Removed `SetHeader(uint8_t const* const first, uint8_t const* const last)`.
+  - Removed `GetMajorVersion()`.
+  - Removed `GetMinorVersion()`.
+  - Renamed `GetBodyStream()` to `ExtractBodyStream()`.
 - Changes to `Azure::Core::Context`:
   - Removed `Get()` and `HasKey()` in favor of a new method `TryGetValue()`.
   - Changed input parameter type of `WithDeadline()` to `Azure::DateTime`.
 - Removed `Azure::Core::PackageVersion`.
 - Removed from `Azure::Core::Http::Policies` namespace: `HttpPolicyOrder`, `TransportPolicy`, `RetryPolicy`, `RequestIdPolicy`, `TelemetryPolicy`, `BearerTokenAuthenticationPolicy`, `LogPolicy`.
-- Renamed `Azure::Core::Http::RawResponse::GetBodyStream()` to `ExtractBodyStream()`.
 - Removed `AppendQueryParameters()`, `GetUrlWithoutQuery()` and `GetUrlAuthorityWithScheme()` from `Azure::Core::Url`.
 - Changed the `Azure::Core::Http::HttpMethod` regular enum into an extensible enum class and removed the `HttpMethodToString()` helper method.
-- Removed `Azure::Core::Http::Request::GetHeadersAsString()`.
 - Introduced `Azure::Core::Context::Key` class which takes place of `std::string` used for `Azure::Core::Context` keys previously.
-- Renamed type `Azure::Core::Http::CurlTransportSSLOptions` to `Azure::Core::Http::CurlTransportSslOptions`.
-- Renamed member `Azure::Core::Http::CurlTransportOptions::SSLOptions` to `Azure::Core::Http::CurlTransportOptions::SslOptions`.
-- Renamed member `Azure::Core::Http::CurlTransportOptions::SSLVerifyPeer` to `Azure::Core::Http::CurlTransportOptions::SslVerifyPeer`.
+- Changed the casing of `SSL` in API names to `Ssl`:
+  - Renamed type `Azure::Core::Http::CurlTransportSSLOptions` to `CurlTransportSslOptions`.
+  - Renamed member `Azure::Core::Http::CurlTransportOptions::SSLOptions` to `SslOptions`.
+  - Renamed member `Azure::Core::Http::CurlTransportOptions::SSLVerifyPeer` to `SslVerifyPeer`.
+
+### Other changes and Improvements
+
+- Moved `Azure::Core::Http::Request` to its own header file from `http.hpp` to `inc/azure/core/http/raw_response.hpp`.
+- Moved `Azure::Core::Http::HttpStatusCode` to its own header file from `http.hpp` to `inc/azure/core/http/http_status_code.hpp`.
 
 ## 1.0.0-beta.7 (2021-03-11)
 
@@ -42,7 +51,6 @@
 - Added `Azure::Core::Operation<T>::GetRawResponse()`.
 - Added `Azure::Core::PackageVersion`.
 - Added support for logging to console when `AZURE_LOG_LEVEL` environment variable is set.
-- Added `Azure::Core::Context::GetDeadline()`.
 
 ### Breaking Changes
 
diff --git a/sdk/identity/azure-identity/CHANGELOG.md b/sdk/identity/azure-identity/CHANGELOG.md
index fb6048f502..174eef3c1b 100644
--- a/sdk/identity/azure-identity/CHANGELOG.md
+++ b/sdk/identity/azure-identity/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## 1.0.0-beta.5 (2021-04-07)
 
+### New Features
+
+- Add Active Directory Federation Service (ADFS) support to `ClientSecretCredential`.
+
 ### Breaking Changes
 
 - Removed `Azure::Identity::PackageVersion`.