You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The BreakingChanges check has a flaw, where it only runs on a file if there is a diff in the PR. So, if a file has a bug so severe it crashes the BreakingChanges check, it won't be detected until later, when the file is changed. This causes significant confusion, because the changes may be unrelated to the original bug.
To mitigate, check BreakingChanges should run on every file in a PR, even if the file is totally new. Any file can be compared "against itself" just to make sure the tool doesn't crash.
The text was updated successfully, but these errors were encountered:
I think we should be able to implement this in a GitHub Action, which also provides a starting point for the overall conversion of BreakingChanges to GH Actions.
The BreakingChanges check has a flaw, where it only runs on a file if there is a diff in the PR. So, if a file has a bug so severe it crashes the BreakingChanges check, it won't be detected until later, when the file is changed. This causes significant confusion, because the changes may be unrelated to the original bug.
To mitigate, check BreakingChanges should run on every file in a PR, even if the file is totally new. Any file can be compared "against itself" just to make sure the tool doesn't crash.
The text was updated successfully, but these errors were encountered: