-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET samples to .NET 8 and Minimal API #3017
Conversation
/azp run azure-dev - template - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posted some initial comments inline. In general:
- Use
TypedResults
overResults
where applicable - Move repeated
WithOpenApi
calls to a single call onMapTodoEndpoints
- Avoid explicit
[FromX]
attributes where the implicit behavior sufficies - Consider using a route group to capture the
/lists
prefix
@captainsafia let me know when you are done with your review and I will do a pass. Appreciate the help! |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
Fix: #3089 |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/3017You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/3017 View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/3017You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/3017 View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/3017You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/3017 View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3017You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/3017 View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3017You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3017 View Changes | Compare Changes |
/azp run azure-dev - cli |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Fix #387