Upgrade v8-compile-cache #2785
Merged
Upgrade v8-compile-cache #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/2785You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/2785View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/2785You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/2785View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/2785You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/2785View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/2785You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/2785View Changes | Compare Changes Project: todo-nodejs-mongo-terraformRemote: azure-samples-stagingBranch: pr/2785You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/2785View Changes | Compare Changes |
wbreza
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #2625
This PR fixes the build break which appears in the nodejs projects. The version of
v8-compile-cacheused inpackage-lock.jsonis not compatible with variations in architecture on the same machine. The later version does support.This was tested with
Azure-Samples/todo-nodejs-*templates and works properly.The scenario in question:
azdon an Apple Silicon Mac in x86_64 mode and init a templateazd package(or some superset command) on the templateazdto a later version using ARM64 binary instead of x86_64 binaryazd package(or some superset command) on the template from step 2In the past this failed with a segfault during the
npm run lintstep in theapi.