Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix devcontainer for todo-java-postgresql-terraform #2597

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

vhvb1989
Copy link
Member

@vhvb1989 vhvb1989 commented Aug 4, 2023

  • Update todo-java-postgresl-terraform devcontainer
  • Fix templates to copy the devcontainer definition explicitly

@azure-sdk
Copy link
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/2597

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/2597

View Changes | Compare Changes


Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/2597

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/2597

View Changes | Compare Changes


Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/2597

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/2597

View Changes | Compare Changes


Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/2597

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/2597

View Changes | Compare Changes


Project: todo-java-postgresql-terraform

Remote: azure-samples-staging

Branch: pr/2597

You can initialize this project with:

azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/2597

View Changes | Compare Changes


Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the repo.yaml for other templates. I think we just need to do java template, todo-csharp-cosmos-sql and todo-csharp-sql. The rest templates have the right devcontainer.json without other folders.

@vhvb1989 vhvb1989 enabled auto-merge (squash) August 4, 2023 21:16
@vhvb1989 vhvb1989 merged commit 2574291 into Azure:main Aug 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants