Add description to all bicep files. #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jongio @savannahostrowski @puicchan can you review the Bicep description updates? |
savannahostrowski
suggested changes
Jul 18, 2023
jongio
reviewed
Jul 18, 2023
templates/common/infra/bicep/core/database/cosmos/cosmos-account.bicep
Outdated
Show resolved
Hide resolved
Yes, we need to honor service name proper casing |
|
@jongio, @savannahostrowski I have updated by your comments, please re-review. Thanks a lot. |
savannahostrowski
suggested changes
Jul 19, 2023
templates/common/infra/bicep/core/security/keyvault-secret.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-account.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-db.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/sqlserver/sqlserver.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/host/container-app-upsert.bicep
Outdated
Show resolved
Hide resolved
puicchan
requested changes
Jul 20, 2023
templates/common/infra/bicep/core/database/cosmos/cosmos-account.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-db.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/sql/cosmos-sql-account.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/sql/cosmos-sql-db.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/security/keyvault-access.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/security/keyvault-secret.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/security/registry-access.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/storage/storage-account.bicep
Outdated
Show resolved
Hide resolved
|
@puicchan @savannahostrowski I have updated by your comments, please re-review. Thanks a lot. |
savannahostrowski
approved these changes
Jul 20, 2023
jongio
reviewed
Jul 28, 2023
jongio
approved these changes
Aug 9, 2023
puicchan
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2466.
@rajeshkamal5050 for notification.