Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First run telemetry notice #2580

Closed
danieljurek opened this issue Aug 1, 2023 · 1 comment · Fixed by #2581
Closed

First run telemetry notice #2580

danieljurek opened this issue Aug 1, 2023 · 1 comment · Fixed by #2581
Assignees
@danieljurek
Labels
cloud shell
Milestone
August 2023 - 1.2.0

Comments

@danieljurek
Copy link
Member

Print telemetry notice on first run.

Conditions: In Cloud Shell AND have not run previously (no ~/.azd/first-run file present)

  1. Disable telemetry for the command
  2. Print telemetry notice
  3. Create ~/.azd/first-run file

Will need some help from @weikanglim to ensure that telemetry is properly disabled.
@danieljurek danieljurek self-assigned this Aug 1, 2023
@weikanglim
Copy link
Contributor

Straightforward way is to update initialize in telemetry.go. If initialize returns nil for TelemetrySystem, telemetry is disabled.

Do you expect the telemetry notice to be printed before, or after the command execution?

@danieljurek danieljurek mentioned this issue Aug 2, 2023
Merged
@rajeshkamal5050 rajeshkamal5050 added this to the August 2023 - 1.2.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieljurek danieljurek

Labels
cloud shell
Projects
None yet
Milestone
August 2023 - 1.2.0
Development

Successfully merging a pull request may close this issue.

Add telemetry notice to azd Azure/azure-dev
3 participants
@danieljurek @weikanglim @rajeshkamal5050