Realign CredentialsRequest to match current ARO operator role definition #3948
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahlmant
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
bitoku
as code owners
bennerv
approved these changes
Nov 8, 2024
|
@bennerv True, since this is just a record of the definition, it could get out of sync. My proposal is to match what ROSA does: any changes must be committed to this repo via a PR before the Azure role definition gets updated. |
|
/azp run ci |
|
No pipelines are associated with this pull request. |
|
Closing in favor of #3953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Partially fixes ARO-12070
What this PR does / why we need it:
Resets ARO Operator CredentialsRequest to the base role definition we have now for MiWi. Prepares it for any future permissions we need to add.
Test plan for issue:
MiWi clusters are already using this definition
Is there any documentation that needs to be updated for this PR?
n/a
How do you know this will function as expected in production?
MiWi clusters are already using this definition