Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added newer linter-rules #826

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Added newer linter-rules #826

merged 3 commits into from
Aug 19, 2024

Conversation

picccard
Copy link
Contributor

@picccard picccard commented Aug 15, 2024

Overview/Summary

Newer bicep releases adds more linter rules.
This PR adds the missing rules from the example linter-config.

If the rules should be error/warning/off...etc. might be changed...

This could potentially be a breaking change.

This PR fixes/adds/changes/removes

  1. Adds more linter rules with default level from the example on ms-docs

Breaking Changes

Could potentially break deployments of customer custom-module
Could potentially break deployments of internal bicep files
No error on any .bicep in ALZ-Bicep repo found, fixes for new warnings in #827

Testing Evidence

Linter in VSCode reports no errors. Warnings is fixed in PR #827

As part of this Pull Request I have

@picccard picccard marked this pull request as ready for review August 15, 2024 13:37
@picccard picccard mentioned this pull request Aug 15, 2024
10 tasks
@picccard
Copy link
Contributor Author

picccard commented Aug 16, 2024

Tests fails on the link checker... dead links found! 💀

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @picccard!! I just changed the no-deployments-resources to error but otherwise I agree with the other levels you incorporated.

@oZakari
Copy link
Contributor

oZakari commented Aug 19, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari added Type: Enhancement ✨ New feature or request Type: Hygiene 🧹 Things related to testing, issue triage etc. labels Aug 19, 2024
@oZakari
Copy link
Contributor

oZakari commented Aug 19, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari merged commit d5a5c52 into Azure:main Aug 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement ✨ New feature or request Type: Hygiene 🧹 Things related to testing, issue triage etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants