Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1 has removed my custom tag #980

Closed
ethicalrevolution opened this issue Nov 10, 2024 · 7 comments
Closed

4.1 has removed my custom tag #980

ethicalrevolution opened this issue Nov 10, 2024 · 7 comments
Assignees
Labels
Needs triage [Type] Bug Something isn't working

Comments

@ethicalrevolution
Copy link

ethicalrevolution commented Nov 10, 2024

Quick summary

I have three sites using ActivityPub and all three have had my custom tag removed on this upgrade which had previously allowed the post to link back to the website with custom text such as ‘read more’. Dashboard screenshot shows where the tag was and is now missing. Mastodon screenshot shows what a post looked like before the tag had been removed (yellow arrow pointing to the rendered tag …I can’t remember exactly how the tags were written in the dashboard side but I had used the documentation to write them originally.)

Steps to reproduce

As above

What you expected to happen

Custom tag to have remained in the box.

What actually happened

It was removed.

Impact

One

Available workarounds?

No and the platform is unusable

Logs or notes

Image
Image

@ethicalrevolution ethicalrevolution added [Type] Bug Something isn't working Needs triage labels Nov 10, 2024
@pfefferle
Copy link
Member

Oh no, I think I forgot to handle the "custom" case! I am so sorry and will fix that asap!

For your issue: It would have been something like <a href="[ap_permalink type="url"]">[Via Ethical Revolution]</a>

@pfefferle pfefferle self-assigned this Nov 10, 2024
@ethicalrevolution
Copy link
Author

Super, thanks for the code. Never any need to be sorry. I’m extremely grateful for your work and am happy to be able to contribute by reporting anything I notice. 👍

@ethicalrevolution
Copy link
Author

I notice you've issued a fix but having updated to 4.1.1 I'm still unable to put the custom link in: I type in '<a href="[ap_permalink type="url"]">[Via Ethical Revolution]' and click save and it then changes itself to just '[Via Ethical Revolution]'.

@pfefferle
Copy link
Member

oh!

@pfefferle
Copy link
Member

Oh sorry, this interferes with the wp_kses! It works if you simply remove the type <a href="[ap_permalink]">[Via Ethical Revolution]</a> or change the double-quotation-marks to single-quotation-marks <a href="[ap_permalink type='url']">[Via Ethical Revolution]</a>.

@ethicalrevolution
Copy link
Author

That's sorted it!

@pfefferle
Copy link
Member

I will close this for now, because the migration is fixed for upcoming migrations and you problem seems also solved. Feel free to re-open if still an issue and sorry one again @ethicalrevolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants