Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting on my own blog post creates a new comment #840

Open
donnchawp opened this issue Aug 6, 2024 · 8 comments
Open

Commenting on my own blog post creates a new comment #840

donnchawp opened this issue Aug 6, 2024 · 8 comments
Labels
Needs triage [Type] Bug Something isn't working

Comments

@donnchawp
Copy link

donnchawp commented Aug 6, 2024

Quick summary

If I comment on a post on my own blog, as my logged in user, a new duplicate comment is made with the same comment text.
The author name is the same too, but the URL is changed to my blog author URL.
The IP is the IP of my server.

Steps to reproduce

  1. Leave a comment on your own blog as your logged in user.
  2. Observe a new duplicate comment generated a few seconds later.

What you expected to happen

The duplicate comment should not have appeared.

What actually happened

Duplicate comment was made a few seconds later.

Impact

Most (> 50%)

Available workarounds?

No but the platform is still usable

Logs or notes

No response

p1722927750475909-slack-C04TJ8P900J

@donnchawp donnchawp added [Type] Bug Something isn't working Needs triage labels Aug 6, 2024
@mediaformat
Copy link
Contributor

confirming!

Screen Shot 2024-08-12 at 4 10 52 PM

@mediaformat
Copy link
Contributor

I haven't looked at the logs, but there are different comment_ids, so I'm guessing wp is somehow federating replies to itself, since the new comment is coming from a remote user!

@solarbirdy
Copy link

Also confirming, and it only seems to be first-level replies. Replies to other people's comments from the Federation do not seem to generate this issue.

@ethicalrevolution
Copy link

Yep, I get this too.

@dzver
Copy link
Member

dzver commented Oct 4, 2024

Happens on https://veselin.blog as well, sandboxed or not

p1727948547147869-slack-C02FMH4G8

@dzver
Copy link
Member

dzver commented Oct 24, 2024

If anyone is curious, this is not resolved and my blog keepes getting duplicate comments.

It's even worse because some actions like approving/moving back a comment to the queue are also capable of generating a duplicate comment.

@pfefferle
Copy link
Member

pfefferle commented Oct 25, 2024

@dzver I made a mistake! I added a "same domain" check, but haven't thought about WordPress.com using a different domain for their endpoints!

https://github.com/Automattic/wordpress-activitypub/blob/1fdca787316d24586d1f6d31593c74005acc264c/includes/class-activity-dispatcher.php#L280C75-L280C89

Sorry about that, I will see how I can check that case!

@dzver
Copy link
Member

dzver commented Oct 25, 2024

No worries, I'm glad you found the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants