Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to use createRoot instead of render #2797

Open
kallehauge opened this issue Aug 14, 2024 · 3 comments
Open

We need to use createRoot instead of render #2797

kallehauge opened this issue Aug 14, 2024 · 3 comments

Comments

@kallehauge
Copy link
Contributor

We need to update our React entrypoint logic to use createRoot instead of ReactDOM.render (see screenshot below):

Screenshot 2024-08-14 at 12 48 38

@iyut
Copy link
Collaborator

iyut commented Sep 3, 2024

Hi @kallehauge ,

After doing some investigating and testing, moving from reactDOM.render() to createRoot().render() seems not as easy as I thought and might need more time to do it. We might need to update the node version and change numbers of dependencies. and also will need to fix the testing script.

This is due to the plugin still use the old node version and some of dependencies that this plugin use is outdated.

Will this be ok to continue?

@kallehauge
Copy link
Contributor Author

Heya @iyut!

Uf! It makes sense, but it's definitely more than I had originally anticipated to make the change 😄

If we update the version, then we should probably do it in a separate PR; but I'm calling in @kloon to give a verdict on if this is worth spending time on now. AFAIK then we're not in any immediate rush with the React warning.

@kallehauge
Copy link
Contributor Author

The last week and a half have been pretty busy, so I'm pinging to make sure it didn't get lost in all the activity: @kloon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants