Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on PHP 8.3 #29

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Test on PHP 8.3 #29

merged 1 commit into from
Jan 2, 2024

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Jan 1, 2024

See: https://www.php.net/releases/8.3/en.php

What and why? 🤔

PHP 8.3 is out, let's confirm every test works as intended.

Testing Steps ✍️

Unit tests.

You're it! 👑

Tag a random reviewer by adding @Automattic/stream-builders to the reviewers section, but mention them here for visibility as well.

@coveralls
Copy link

Coverage Status

coverage: 79.4%. remained the same
when pulling 5a7a532 on sanmai-patch-1
into 03750e8 on main.

@sanmai sanmai requested review from a team and jbao and removed request for a team January 1, 2024 13:33
@sanmai sanmai enabled auto-merge (squash) January 1, 2024 13:33
Copy link
Contributor

@cyle cyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@sanmai sanmai merged commit 6cca8f6 into main Jan 2, 2024
9 checks passed
@sanmai sanmai deleted the sanmai-patch-1 branch January 2, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants